set displayName to name by default
#9719
Conversation
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #9719 +/- ##
============================================
- Coverage 16.23% 4.00% -12.24%
============================================
Files 5657 402 -5255
Lines 498865 32686 -466179
Branches 60545 5817 -54728
============================================
- Hits 80991 1309 -79682
+ Misses 408843 31222 -377621
+ Partials 9031 155 -8876
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11176 |
|
@DaanHoogland the API response does have the "displayname" in place. but the name/displayname is not displayed on UI. as a simple workaround, can we revert #8503 ? @DaanHoogland |
yes, you are right, I'll creat another PR, reapply the changes here, and work on this later. |
|
@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
DaanHoogland
force-pushed
the
defaultDisplayName
branch
from
b7a8a71 to
7e3bf26
Compare
sureshanaparti
changed the title
desplayName to name by defaultdisplayName to name by default
ui/src/config/section/compute.js
Outdated
| }, | ||
| columns: () => { | ||
| const fields = ['name', 'state', 'ipaddress'] | ||
| const fields = ['displayname', 'state', 'ipaddress'] |
There was a problem hiding this comment.
| const fields = ['displayname', 'state', 'ipaddress'] | |
| const fields = ['name', 'state', 'ipaddress'] |
ui/src/config/section/compute.js
Outdated
| return fields | ||
| }, | ||
| searchFilters: ['name', 'zoneid', 'domainid', 'account', 'groupid', 'arch', 'tags'], | ||
| searchFilters: ['displayname', 'zoneid', 'domainid', 'account', 'groupid', 'arch', 'tags'], |
There was a problem hiding this comment.
| searchFilters: ['displayname', 'zoneid', 'domainid', 'account', 'groupid', 'arch', 'tags'], | |
| searchFilters: ['name', 'zoneid', 'domainid', 'account', 'groupid', 'arch', 'tags'], |
3 participants
Description
This PR prevents a null display name on VMs (see #8503 (comment))
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?